Add DeviceCodes::poll_until_available method
#679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrasnitski
force-pushed
the
oauth-poll
branch
from
52e85ae to
4141a62
Compare
|
Thank you for your PR! |
Merged
benpueschel
pushed a commit
to benpueschel/octocrab
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polling behavior is specified by the GitHub API (such as waiting minimum 5 seconds between polls and what to do if you get a
slow_downerror). Therefore, it would be best for users not to implement this logic themselves as they may get it wrong. In principle it might even be a good idea to remove thepoll_oncemethod and just havepoll_until_available.I'm not sure if
await-ing this function will actually block, but I'm assuming tokio will properly schedule other things while we're waiting to poll.